Update ideogram#393
Conversation
|
Wow, does it just work? I'd be curious to know what happened on Ideogram's and/or our end to resolve whatever issues had been blocking so far... |
|
Haha quite honestly I am not sure why there aren't any failed tests, I was fully expecting there to be. I have tried to update the version before and I believe there were failed tests then. I think it might be worth double checking to make sure that things work as expected. As well, since the existing ideogram tests are not very reliable anyway, I am working on a rewrite of them using ideogram version 1.10.0. |
|
Right, I'm not sure that any of the Ideogram-related tests we currently have would capture the past issues we were experiencing... You may want to look at these issues https://github.com/eweitz/ideogram/issues/created_by/matthewchan15 and maybe #186 (?). |
|
Lol i think i figured out what happened, the tests are still using the old version of ideogram. I looked at the deployed version and its missing features and fixes which I know were added in 1.10.0. Same thing is probably happening in the tests. If you go to the deployed version, go click on Ideogram demo, and then in the console paste |
|
@mj3cheun Could you increment the version of the package, regenerate the bundle, and republish to PyPI/NPM? |
…rops; move prop names out of ideogram object.
These variables are no longer created by ideogram.
|
Closed via #667 |
4 participants
This PR will also implement the work in #380:
ideogram, which assign towindow.chrBandsAbout
Description of changes
Before merging